Assessment for Marking up a letter want to upgrade

This post was flagged by the community and is temporarily hidden.

Hi @samkuteesa and welcome to the community :wave:

Nice work on your first exercise. :clap:

Here are some comments:

  • When using an online editor like JSFiddle you can just copy the CSS from the exercise to its panel on JSFiddle (like you did with the HTML and the HTML panel).
  • The <address> tag should include everything from the name to the email address.
  • When you have copied the CSS you can also use the sender-column class on the <address> and remove the <div>.
  • You don’t need the <p>s inside the addresses.
  • The semester dates also need <time> tags.
  • It would probably be a good idea to use a unordered list for the “Subjects of study”.
  • In the footer: You should use a <q> tag around the quote and a <cite> tag around the source.

I hope that helps. If you have any questions, feel free to ask. :slightly_smiling_face:

Have a nice day,
Michael

Thanks Michael,
Let me work upon this because want to finish and go to structuring.
My question is about the online editor wat do I need to do?like should write the CSS my self?

No, that’s not necessary. The CSS is linked on the task page:

In later exercises it’s in the HTML file inside <style> tags and can be copied from there. Almost all exercises have some starting code which includes HTML, CSS (and later JS).

This post was flagged by the community and is temporarily hidden.

AM requesting if there’s any way i can show my update on what have improved because posting a new link here is scam

Hi @samkuteesa

I happens from time to time that posts of new users automatically get marked as spam, because of the links. I’ve informed the admins some time ago, but unfortunately they don’t have a solution, yet.
If this should happen in the future, you can put the link inside backticks (`) like this:

`https://jsfiddle.net/Skcode/s41Lqmz5`

This will display the link as normal text and helped other users in the past.

The good thing is that I can still see your improved version. So let’s have a look:

  • You correctly integrated the CSS into JSFiddle. That was exactly what I meant.
  • Each address should have it’s own <address> tag and you need another <p class="sender-column"> around the <time> element.
      <address class="sender-column">
        ...
      </address>
    
      <p class="sender-column">
        <time datetime="2016-01-20">20 January 2016</time>
      </p>
    
      <address>
        ...
      </address>
    
  • The semester <time> elements are nearly correct. The datetime attributes has to be in the format “yyyy-mm-dd”. So you need to add zeros were needed. (e. g. datetime="2016-09-09"
  • The unordered list is still missing from the “Subjects of study”.
  • The footer is much better. The only thing left is that you can leave the quotes out, because <q> adds them automatically.

Happy coding,
Michael

1 Like

Thanks for the feedback Micheal

1 Like