# Assessment wanted for marking up a letter - 1

**URL:** <https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-1/94790>\
**Category:** Learn\
**Created:** [March 19, 2022, 3:13pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-1/94790 "2022-03-19T15:13:47Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![hs224](https://avatars.discourse-cdn.com/v4/letter/h/b487fb/32.png) [@hs224](https://discourse.mozilla.org/u/hs224)\
**Post date:** [March 19, 2022, 3:13pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-1/94790/1 "2022-03-19T15:13:47Z")

</div>

Hi, I am looking forward to an assessment for my HTML code that I wrote for marking up a letter. Any indication of mistakes, suggestions, or improvements is welcome. The link to the marked up letter is as follows:

https://codepen.io/hafsa27/embed/preview/MWrwLjK?default-tabs=html%2Cresult&height=300&host=https%3A%2F%2Fcodepen.io&slug-hash=MWrwLjK

Here’s the link to the MDN page that contains the assessment assignment:

> **[Challenge: Marking up a letter - Learn web development | MDN](https://developer.mozilla.org/en-US/docs/Learn_web_development/Core/Structuring_content/Marking_up_a_letter)**
>
> We all learn to write a letter sooner or later; it is also a useful example to test our text formatting skills. In this challenge, you'll have a letter to mark up as a test for your HTML text formatting skills, as well as hyperlinks and proper use of...

---

<div class="post-metadata">

**Author:** ![justsomeone](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/justsomeone/32/67787_2.png) [@justsomeone](https://discourse.mozilla.org/u/justsomeone)\
**Post date:** [March 19, 2022, 4:13pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-1/94790/2 "2022-03-19T16:13:40Z")

</div>

elslamo alikom @hs224

you doing great well done just little notice here

1. the first address should start from the `Dr. Eleanor Gaye` till the email so no need div element and give this address the class you give for the div

2. by the way address make it content italic by default so not need to wrap anything with em

3. the time element after the first address you could wrap it with p element and give it the same class

4. do the same thing with the second address and of course without the class

5. some of the time element you forget to set `datetime` value for it and sometime you forget the time element check the semester list

6. you can copy the css code in the css panel in codepen and it will still work of course you will learn many ways when you reach the css lessons

7. your email already displayed next to your email so try to hide it from your profile page

hope that help and have a nice day 🙂

---

<div class="post-metadata">

**Author:** ![hs224](https://avatars.discourse-cdn.com/v4/letter/h/b487fb/32.png) [@hs224](https://discourse.mozilla.org/u/hs224)\
**Post date:** [March 19, 2022, 9:34pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-1/94790/3 "2022-03-19T21:34:36Z")

</div>

Hi @justsomeone, thankyou for the feedback. It was really helpful. 💯

---

<div class="post-metadata">

**Author:** ![justsomeone](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/justsomeone/32/67787_2.png) [@justsomeone](https://discourse.mozilla.org/u/justsomeone)\
**Post date:** [March 20, 2022, 11:38am UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-1/94790/4 "2022-03-20T11:38:22Z")

</div>

@hs224 you very welcome and happy coding 🙂