# Assessment wanted for Marking up a letter(learning)

**URL:** <https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-learning/107684>\
**Category:** Learn\
**Tags:** learning\
**Created:** [November 13, 2022, 8:48am UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-learning/107684 "2022-11-13T08:48:34Z")\
**Posts on this page:** 5\
**Page:** 1

<div class="post-metadata">

**Author:** ![jessen\_wzd](https://avatars.discourse-cdn.com/v4/letter/j/65b543/32.png) [@jessen\_wzd](https://discourse.mozilla.org/u/jessen_wzd)\
**Post date:** [November 13, 2022, 8:48am UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-learning/107684/1 "2022-11-13T08:48:35Z")

</div>

As a beginner, I hope to get everyone’s score evaluation, thank you very much !  
Below is the code link:  
[https://jsfiddle.net/jessen\_W/fs8qzto1/9/](https://jsfiddle.net/jessen_W/fs8qzto1/9/)

---

<div class="post-metadata">

**Author:** ![mikoMK](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/mikomk/32/50456_2.png) [@mikoMK](https://discourse.mozilla.org/u/mikoMK)\
**Post date:** [November 21, 2022, 2:03am UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-learning/107684/2 "2022-11-21T02:03:54Z")

</div>

Hi @jessen_wzd and welcome to the community 👋

Great work on your first big exercise! 👏

Here are some small improvements:

- The first `<time>` doesn’t belong to the address. It needs its own `<p>` with the `sender-column` class.
- There’s a missing space in front of the “important university dates” link.
- You’re first `</sup>` has an additional `>`.

That’s it. As you see, just some minor things. 🙂

Have a nice day,  
Michael

---

<div class="post-metadata">

**Author:** ![enfash](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/enfash/32/60185_2.png) [@enfash](https://discourse.mozilla.org/u/enfash)\
**Post date:** [November 21, 2022, 2:32pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-learning/107684/3 "2022-11-21T14:32:42Z")

</div>

As a beginner, I hope to get everyone’s score evaluation, thank you very much !  
Below is the code link:

[My Assessment](https://codepen.io/enfash/pen/OJEOaEp)

---

<div class="post-metadata">

**Author:** ![mikoMK](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/mikomk/32/50456_2.png) [@mikoMK](https://discourse.mozilla.org/u/mikoMK)\
**Post date:** [November 26, 2022, 10:13pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-learning/107684/4 "2022-11-26T22:13:19Z")

</div>

Hi @enfash and welcome to the community 👋

Nice work on your first big exercise. 🎉

A lot of your code is correct. Here are some points that could be improved:

- The first date isn’t part of the address. You should put it inside it’s own `<p>` after the address (with the same class to align it).
- You should use [`<time>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time) for all the dates.
- Have a close look at the numbers in the “Subjects of study” list. Some of them should be higher or lower. You can achieve that with [`<sup>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/sup) and [`<sub>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/sub).
- The underlined abbreviations should use [`<abbr>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/abbr) instead of `<u>`.
- For the “Polynesian chicken dance” a [description list](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl) would be a good choice.
- For the quote at the end you could use [`<q>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/q) and [`<cite>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/cite).

I hope that helps. Feel free to ask questions if you like. 🙂

See you,  
Michael

---

<div class="post-metadata">

**Author:** ![enfash](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/enfash/32/60185_2.png) [@enfash](https://discourse.mozilla.org/u/enfash)\
**Post date:** [November 29, 2022, 5:37pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-marking-up-a-letter-learning/107684/5 "2022-11-29T17:37:33Z")

</div>

Thanks you for your reviews… i will amend and revert as soon as possible  
thanks