Assessment wanted for Marking up a letter :)

Hi guys,

I’m seeking assessment and feedback on Marking up a letter from the Intro to HTML lessons.

Challenge:

Solution:

I have some questions from this assessment too if anybody is able to help out on them. When is the best time to use a <p> element? After I put the entire text of the letter into the <body> all of the text just rendered and I was able to start applying elements to certain parts. For example should a <ul> be nested within a <p> or is it fine to stand alone? My gut feeling is that if a tag is a block-level element, it doesn’t need to be nested. But if a tag is inline-level then it should have been nested. That is the approach I tried to use on this assignment.

Thanks guys,
Logan

Hi @Mahoney

I haven’t had time to look at your task, but I just wanted to mention that the forum “ate” your elements in your additional questions. Could you please edit your post and use backticks around those elements like `<p>` or `<div>`. So we can see them. Thanks! :slightly_smiling_face:

Cheers,
Michael

Done, Thank you sir!

I now had time to look at your task.
Congratulations, great job! :medal_sports:

Two tiny improvements:

  • No need for the <div> around <address>. <address class="sender-column"> is fine.
  • As by the task description the links should also include a title attribute.

Regarding your question
<p> is called “The paragraph element”. So you will mostly use it to group running text like you find in articles or this very letter you marked up. There’s no need to wrap <ul> with <p>. <ul> itself is a block element representing a list and can be used on the same level as <p> like we saw in this task.
Technically speaking every inline element is wrapped by a block element as <body> itself is a block element. But it isn’t necessary to additionally wrap every inline element as long as it does what it should.

I hope that helps! Feel free to ask more questions.

See you,
Michael

1 Like

I’ve made those changes!

Thanks for your feedback and answer. Thinking about the <body> as a block level element itself wrapping the content does help.

1 Like