# Assessment wanted for my "Typesetting a community school homepage"

**URL:** <https://discourse.mozilla.org/t/assessment-wanted-for-my-typesetting-a-community-school-homepage/99160>\
**Category:** Learn\
**Created:** [July 1, 2022, 12:51pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-my-typesetting-a-community-school-homepage/99160 "2022-07-01T12:51:38Z")\
**Posts on this page:** 7\
**Page:** 1

<div class="post-metadata">

**Author:** ![tuhamworld](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/tuhamworld/32/55941_2.png) [@tuhamworld](https://discourse.mozilla.org/u/tuhamworld)\
**Post date:** [July 1, 2022, 12:51pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-my-typesetting-a-community-school-homepage/99160/1 "2022-07-01T12:51:39Z")

</div>

Hello, I would very much appreciate if my code for : [Typesetting a Community School Homepage](https://developer.mozilla.org/en-US/docs/Learn/CSS/Styling_text/Typesetting_a_homepage) is reviewed.

Here’s my link on CodePen: [https://codepen.io/tuhamworld/pen/XWEJvYw](https://codepen.io/tuhamworld/pen/XWEJvYw)

Thank you

---

<div class="post-metadata">

**Author:** ![mikoMK](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/mikomk/32/50456_2.png) [@mikoMK](https://discourse.mozilla.org/u/mikoMK)\
**Post date:** [July 5, 2022, 7:49pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-my-typesetting-a-community-school-homepage/99160/2 "2022-07-05T19:49:33Z")

</div>

Well done, @tuhamworld!

Here are some small possible improvements:

- Maybe use a different color for unvisited and visited links.
- To make the selector for the external link icons more general, you could use the following attribute selector `a[href^="http"]`. It selects all links which `href` attribute starts with “http” (no matter where they would be on the page). More on attribute selectors: [https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute\_selectors](https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors).
- You could add

```auto
width: 100%;
display: inline-block;

```

to the last rule. This would make the link cover the whole `<li>` box.

I hope that helps. 🙂

Stay safe,  
Michael

---

<div class="post-metadata">

**Author:** ![tuhamworld](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/tuhamworld/32/55941_2.png) [@tuhamworld](https://discourse.mozilla.org/u/tuhamworld)\
**Post date:** [July 6, 2022, 3:19pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-my-typesetting-a-community-school-homepage/99160/3 "2022-07-06T15:19:39Z")

</div>

Thank you for the help and kind review.

I have made those adjustments.  
Could you please recheck now?

---

<div class="post-metadata">

**Author:** ![mikoMK](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/mikomk/32/50456_2.png) [@mikoMK](https://discourse.mozilla.org/u/mikoMK)\
**Post date:** [July 6, 2022, 6:22pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-my-typesetting-a-community-school-homepage/99160/4 "2022-07-06T18:22:25Z")

</div>

Nice work!

On the last selector you are now missing `> a`. (It should target the `<a>` **inside** `<li>` - not the `<li>` itself.

The rest is fine.

---

<div class="post-metadata">

**Author:** ![tuhamworld](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/tuhamworld/32/55941_2.png) [@tuhamworld](https://discourse.mozilla.org/u/tuhamworld)\
**Post date:** [July 7, 2022, 6:07am UTC](https://discourse.mozilla.org/t/assessment-wanted-for-my-typesetting-a-community-school-homepage/99160/5 "2022-07-07T06:07:53Z")

</div>

No wonder the link are being underlined.

I have done that just now.

Thank you

---

<div class="post-metadata">

**Author:** ![mikoMK](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/mikomk/32/50456_2.png) [@mikoMK](https://discourse.mozilla.org/u/mikoMK)\
**Post date:** [July 7, 2022, 2:00pm UTC](https://discourse.mozilla.org/t/assessment-wanted-for-my-typesetting-a-community-school-homepage/99160/6 "2022-07-07T14:00:45Z")

</div>

Much better. Well done! 👍

---

<div class="post-metadata">

**Author:** ![tuhamworld](https://sea1.discourse-cdn.com/flex001/user_avatar/discourse.mozilla.org/tuhamworld/32/55941_2.png) [@tuhamworld](https://discourse.mozilla.org/u/tuhamworld)\
**Post date:** [July 10, 2022, 7:01am UTC](https://discourse.mozilla.org/t/assessment-wanted-for-my-typesetting-a-community-school-homepage/99160/7 "2022-07-10T07:01:57Z")

</div>

Thank you for the review. 🙂