Assessment wanted for Structuring planet data | gojanpaolo

Hello, please assess my solution for https://developer.mozilla.org/en-US/docs/Learn/HTML/Tables/Structuring_planet_data

My solution: https://codepen.io/gojanpaolo/pen/VwepjPB

Thanks!

Hi there @gojanpaolo!

What you’ve done here largely produces the right results, but the way you’ve done the rowgroup headings is not quite right. You’ve put them in separate rows, whereas actually you need to put them in the same rows as the other headings and cells, and then the rowspan / colspan numbers make a bit more sense.

Have a look at how we did it here: https://github.com/mdn/learning-area/blob/master/html/tables/assessment-finished/planets-data.html

1 Like

@chrisdavidmills Thanks for assessing my solution. That is what I actually did at first. But then I realized that when we bind it to data we’ll probably have a planet class/interface, and then we’ll map each planet to a row.