Help on the dialer


(Valentin) #1

Hi!

@gsvelto could use someone’s help:
The person we’re looking for to help out with the dialer should have good JavaScript skills, and should be interested about learning some of the internals of Gecko (e.g. the difference between regular and chrome code, how the telephony API works). The work involves porting the code of a trimmed down dialer to chrome code and ensuring that basic functionality works (making/receiving calls, displaying the call log would be a bonus). We’re not looking at handling contacts yet at this stage, only basic number-based operation so that we have a simple foundation to build upon.

It’s a good opportunity to learn about the telephony side on B2G.
If you’re interested, please contact Gabriele here or on IRC, he’s @gsvelto on both.


(Alastair Pharo) #2

Hi there,

I’d be interested to help out if a helper is still being sought.


(Gabriele Svelto) #4

Alastair I’ve posted a short list of good first bugs in the dialer here: https://discourse.mozilla-community.org/t/dialer-and-other-apps/8839/5?u=gsvelto


(Lapineige) #5

I can’t access to the topic:

Sorry, you don’t have access to that topic!

Am I the only one ?


(Gabriele Svelto) #6

Silly me, it’s a message not a public topic :blush: Here’s the bugs:

https://bugzilla.mozilla.org/show_bug.cgi?id=1044028
https://bugzilla.mozilla.org/show_bug.cgi?id=1057321
https://bugzilla.mozilla.org/show_bug.cgi?id=1077073

These are all relatively simple bugs to fix so that one can get acquainted with the code.


(Gabriele Svelto) #7

The full list of bugs is here:

https://bugzilla.mozilla.org/buglist.cgi?product=Firefox%20OS&component=Gaia%3A%3ADialer&resolution=---&list_id=13061640

There’s a lot of old stuff in there and I’m going over it trying to close all the bugs that don’t make sense any more. Feel free to open new ones for issues you encounter while using the dialer and also for design and functionality change. With the project being transitioned to the community we’re not limited by a roadmap or pre-existing designs.


(Gabriele Svelto) #8

This one is also interesting though it might require a little more effort:

https://bugzilla.mozilla.org/show_bug.cgi?id=1014597


(Gabriele Svelto) #9

Finally this is a list of the bugs we deemed more important. It hasn’t been updated in a while but it’s also a good resource for finding good first bugs.

https://bugzilla.mozilla.org/show_bug.cgi?id=1036516


(Lapineige) #10

Thanks @gsvelto for these resources ! :slightly_smiling:


(Alastair Pharo) #11

@gsvelto, thanks. I’ll see if I can work on one of these today!


(Krz37) #12

@asppsa Which one will you be working on?


(Alastair Pharo) #13

Hey, so I’ve looked at those three bugs:

  • Bug 1044028 appears to depend on the contacts API. Is this working in B2G OS yet?
  • Bug 1057321 requires two SIMs. My device (Nexus 4) doesn’t have this, so I’m not sure I can work on this, unless there’s some way I can repro with an emulator perhaps. Or maybe as a unit test, with some mocking?
  • Bug 1077073 also seems like it would be best addressed
    via some kind of mock-based unit testing, as it seems like it will be hard to repro otherwise.

I think I’ll make an attempt on 1077073, unless anyone has a better idea?


(Alastair Pharo) #14

Hi again,

I’ve not been able to run the existing suite of unit tests for the dialer (not even to see the tests fail). Is anyone able to confirm whether they are currently expected to work? If not, any ideas on what it would take for them to be able to run?