Macro reviews needed

I’ve got two PRs up for changes to macros responsible for generating lists of pages on a wide variety of MDN’s pages. These need to be reviewed before the PRs can be accepted and make their way toward production.

Is anyone able to have a look? They’re not trivial. :slight_smile:

They are:

PR #386: Refactor SubpagesWithSummaries and MakeColumnsForDL
Updates the main macro that builds lists of pages and their summaries into a <dl> and the macro that takes a <dl> and breaks it into a two-column layout. These are used on landing pages quite frequently.

PR #388: Refactor SubpagesWithTags and add SubpagesWithTagsOneCol
Updates the macro that builds a subpages list that includes only pages that match one of a set of specified tags. The main logic of this is moved into SubpagesWithTagsOneCol, which outputs a one-column <dl> of these pages. The original macro’s output remains unchanged but it works by calling through to the OneCol version before then dividing the results into two columns.

If anyone can review these, I’d appreciate that.

Eric Shepherd
Senior Technical Writer
MDN Web Docs: https://developer.mozilla.org/
Blog: http://www.bitstampede.com/
Twitter: http://twitter.com/sheppy