So I tried adding them to Thing.h and ESPWebThingAdapter.h in the same way that unit and readOnly are added and it seems to work!
Thing.h
class ThingItem {
public:
String id;
String description;
ThingPropertyType type;
String atType;
ThingItem* next = nullptr;
bool readOnly = false;
String unit = "";
// this is what I added
String title = "";
double minimum;
double maximum;
ESPWebThingAdapter.h
if (item->readOnly) {
prop["readOnly"] = true;
}
if (item->unit != "") {
prop["unit"] = item->unit;
}
// this is what I added
if (item->title != "") {
prop["title"] = item->title;
}
if (item->minimum < item->maximum) {
prop["minimum"] = item->minimum;
}
if (item->maximum > item->minimum) {
prop["maximum"] = item->maximum;
}
Which suggests that I need write access to create a branch
Anyone with read permissions to a repository can create a pull request, but you must have write permissions to create a branch.
I did so and tried to push the changes but I got this error:
remote: Permission to mozilla-iot/webthing-arduino.git denied to lundsholm.
fatal: unable to access 'https://github.com/mozilla-iot/webthing-arduino.git/': The requested URL returned error: 403
EDIT: @mstegeman Let me know if I should contact you any other way to keep this thread clean and on topic