Issues submitting an addon

Oh actually it just seems it couldnt launch it in Firefox.

@Tanookirby please download and try installing the XPI from this repository - https://github.com/Noitidart/AutoPagerizeTweaked

If it works, then please go ahead and upload that to AMO and let me know. I will record a video of how I did that.

The option menu where you can update the rules and add exceptions is missing here. Other than that, it works fine.

Can you take a screenshot and show me please what it should look/work like

Download and install the original xpi that I uploaded and look for the addon on the extension list. Click Options and then “Open AutoPagerize Preferences.”

Oh I think I see. Please take the options.xul file from the origianl xpi and add it to my xpi, then please install to firefox and test, it should work. If it works let me know and I’ll repackage it and post a video of how i do it.

Nothing happens when I press the preferences button.

I managed to solve the preferences issue myself. Link to updated addon is below.

http://www.mediafire.com/download/uhh45zkmctqjluh/autopagerizetweaked-0.9.17.4.xpi

Do you have a github? Could you make a pull request to my repository? So I can easily see what changes you made and repackage the addon.

I changed the options.xul file. More specifically, the oncommand attribute in line 4. I replaced the string jid0-tKjnEA5X3eBoP5HnqjBYQ4U3AcM@jetpack with @autopagerizetweaked.

1 Like

Finally made a github account of my own. Here it is.

1 Like

Nice I’ll make a pull request to it with the files and a video of how i do it

Here is a video showing the process of repacking the addon sdk addon - https://www.youtube.com/watch?v=VTwioTr7TpY

That vid also shows how to make a pull request to Github

Go ahead and submit that xpi to amo it will be accepted

The addon has been submitted and is pending approval. In the meantime, I’d like to have an option in the preferences window the toggles the page break on and off. Currently, all of the lines of code in data/autopagerize.user.js that involve displaying it are commented, (found within lines 374-390). It would be nice for users to have a choice.

There is also an issue of javascript elements not being able to load. Example: http://www.rollingstone.com/tv/news

Those questions are for the original developer, or another topic if yo uwant to take over this addon. I was helping you with the issue of submitting your addon.

By the way I can’t find the submission on AMO, can you link me to it.

Sure.
https://addons.mozilla.org/en-US/firefox/addon/autopagerizetweaked/

Uh-oh, it appears that this addon will not work on certain pages. Sites like http://supernaturalislife.com/ will work with the original Autopagerize extension but not my version.

Well, it’s been awhile since I posted here, but I’ve come across a new problem. I tried to make an update to AutopagerizeTweaked; and not long after submitting it, I got this message:

This version didn’t pass review because of the following problems:

1. After click Open AutoPagerize preferences button nothing happens.

_2. DOM mutation events profoundly degrade performance, and that _
_degradation is not reversed by removing the listeners. We can’t allow _
_mutation listeners except when they’re absolutely necessary, and never _
_for the top-level browser document. Please see https://developer.mozilla.org/en/XUL_School/Appendix_F:Monitoring_DOM_changes for more information.

How could I correct this?

Was this the result of an automated or a manual review?

I’m fairly certain it was manual.

Ok.

Regarding the first point: The reviewers test the basic functionality. “After click Open AutoPagerize preferences button nothing happens.” Sounds like it simply didn’t work.

Regarding the second point: The version that is online at amo contains this line: https://addons.mozilla.org/en-US/firefox/files/browse/376379/file/data/autopagerize.user.js#L84
There is a good chance that the reviewer simply mistook this for an actual DOMNodeInserted event listener.