Sentence Collector Localization Update

https://pontoon.mozilla.org/cy/common-voice/all-resources/?status=missing&string=235053

1 Like

@rprys thanks for reporting this. I will have a look. This was not meant as a comment on that specific string, you can safely ignore it.

1 Like

One more thing to be aware of - a minor issue… If the original sentence has a variable AND it is a correct English word ( e.g. {$sentences} ) AND if you use Google translation to start with, you get that variable also translated. Pontoon will give an error, stating there is no closing “}”. To pass that, you should correct the variable name of course…

1 Like

I’m not sure what ‘total sentences’ mean. The number of sentences or if they are complete?

0 No total sentences.
one 1 total sentence.
other { $totalSentences } total sentences.

GROUP COMMENT Validation criteria

CONTEXT sc-lang-info-total

RESOURCE Common Voiceweb/locales/en/messages.ftl

https://pontoon.mozilla.org/cy/common-voice/all-resources/?status=missing&string=235049

Should the keyboard shortcuts be localized?
They would be C, G and H in Welsh for Cymeradwyo, Gwrthod a Hepgor?

You can also use Keyboard Shortcuts: Y to Approve, N to Reject, S to Skip

GROUP COMMENT Validation criteria

CONTEXT sc-review-form-keyboard-usage

RESOURCE Common Voiceweb/locales/en/messages.ftl
https://pontoon.mozilla.org/cy/common-voice/all-resources/?status=missing&string=235041

Contributions Agreement template
Will these be available for localization?

Will there be a separate staging site for the Sentence Collector?
These’s a lot to check :slight_smile:

“x total sentences” is from the first bullet on the Statistics page, showing total posted sentences in a language, validated or not.
https://commonvoice.mozilla.org/sentence-collector/#/en/stats

About keyboard shortcuts:

No, these are checked by the SW as keypresses, as of now these cannot be localized.

Contributions Agreement template (and Wikipedia link etc) are in English only.

Formally translating the Agreement for 150+ languages will not be possible I think. Also, although Wikipedia link has several translations, it is not in every language.

Thanks, so how about:
0 No sentences
one 1 sentence
other a total of { $totalSentences }

https://commonvoice.mozilla.org/sentence-collector/#/en/stats isn’t showing this on my profile.

The keyboard shortcuts are localized here: https://commonvoice.mozilla.org/cy/speak

Please just hit “Statistics” from the top menu in Sentence Collector. Most of these 3 option translations are from the Statistics page. They all are indicated with context:
CONTEXT sc-lang-info-*

image

Thanks, what I’m seeing is

Statistics

Last Update: ⁨18/11/2021 14:54:27⁩

The Common Voice Sentence Collector has collected ⁨0⁩ sentences in ⁨0⁩ languages!

What you’ve shown looks more useful :slight_smile:

1 Like

Oh, now I see! You should have contributed some :slight_smile:
Currently “zero” cases are controlled in the SW and no output is shown. But we added them in case the SW changes in this respect.

There should be some already - we have 134 hour of recordings!
Or do I need to add some now?

Sentence Collector is not in the same repo, it is maintained separately. So current code does not take localized keyboard shortcuts yet. You can file a feature request for it of course :slight_smile:

Not likely, but @mkohler can answer that one more precisely.

As indicated it is in a different repo, but it has been decided to add the sentences to the main CV Pontoon, thus into CV repo. Although CV has a staging server in Pontoon, as SC does not have a separate project in Pontoon and it is not directly part of CV a staging server is not directly applicable.

It is possible to install SC locally and test it somehow but it will require lots of work. I think we will see it online and correct possible mistakes afterward.

This cannot be true…

Statistics

Last Update: ⁨11/18/2021, 5:30:17 PM⁩

The Common Voice Sentence Collector has collected ⁨4,553,176⁩ sentences in ⁨131⁩ languages!

That should be the same with your output…

And you already should have ~15000 sentences in “cy”, in addition to PR’d ones…

Are you using a separate installation? Don’t you use this one?

https://commonvoice.mozilla.org/sentence-collector/

I tried another computer with Firefox 94.01 on it and Firefox ESR 91.3.0 and it came though the same as yours. :slight_smile:

But Firefox Nightly 96.0a1 (2021-11-18) is still showing:

Statistics

Last Update: ⁨18/11/2021 14:54:27⁩
The Common Voice Sentence Collector has collected ⁨0⁩ sentences in ⁨0⁩ languages!
:man_shrugging: