Hi @martinp, thanks for submitting your version of the assessment. Let’s have a look…
OK, a few bits to comment, but overall this looks pretty good. Nice effort!
- In the following rule, where you set the base font family and size for the entire document, you are better off setting this on the
<html>
element instead, so it will definitely apply to everything. If you set it on the body, you sometimes get unexpected behaviour.
body {
font-family: libre;
font-size: 10px;
}
-
Your code isn’t generally indented very much — it is a good idea to indent the declarations by two spaces, so they are easier to read.
-
Re: Your comments about
::first-line
and:first-child
. Yeah, you didn’t need these, and how they work is possibly a little unexpected. the former only really works when attached to a selector that selects a block level element with multiple lines of text in it, e.g.p::first-line
to select the first line of all paragraphs. The latter selects the element it is attached to, if it is the first child of another element, so e.g. if you have three paragraphs inside your body,p:first-child
would select the first one of those. If you have a div followed by two paragraphs, nothing would be selected, as there is no paragraph that is the first child of something. -
Re: " this doesn’t change anything at all " in reference to setting
line-height: 1.5
on your list items. Correct. This is because you already setline-height: 1.5
on yourul
/ol
s earlier in the code, and theli
s inherit it from them.
That’s the only major-ish stuff. If you want to explore our code and marking guide in more detail, see the links earlier in the thread.
With reference to spam, I am not sure what you mean; you replied by e-mail to posts on this thread, and it got marked as spam? Sorry to hear you had trouble there; I didn’t see any spam. I always go to the page and reply, and don’t seem to have any troubles. There isn’t a dedicated IRC channel for learning area help, although I think there probably should be. I might look at setting it up.
For now, the best IRC channel is probably #mdn. I’m in there as chrisdavidmills, and you are welcome to ping me and ask for help if I’m around.