stig
(Stig Nygaard)
February 9, 2020, 4:28pm
1
For some time I haven’t seen the “Release notes” paragraph on the installation pages of my browser extensions. But then suddenly one day I saw it on one of my extension, only for being gone the next time I visited the installation page.
Digging deeper, it looks like it isn’t visible on “en-GB” version of the installation page. But it is visible on f.ex “da”, “es” and “en-US” versions of the install page? :
Download xIFr for Firefox. EXIF viewer. Powerful tool to see EXIF, IPTC and XMP metadata in images. Including geo-coordinates ("GPS location"), and map-view of location.
xIFr uses "deep search" to find images that normally can't be selected just by...
Download xIFr for Firefox. EXIF viewer. Powerful tool to see EXIF, IPTC and XMP metadata in images. Including geo-coordinates ("GPS location"), and map-view of location.
xIFr uses "deep search" to find images that normally can't be selected just by...
Descargar xIFr para Firefox. EXIF viewer. Powerful tool to see EXIF, IPTC and XMP metadata in images. Including geo-coordinates ("GPS location"), and map-view of location.
xIFr uses "deep search" to find images that normally can't be selected just...
jscher2000
(jscher2000)
February 9, 2020, 8:05pm
2
Hmm, same problem on the /versions page.
Puzzling why en-GB doesn’t fall back to the default locale for release_notes as it does for the other fields, and as other locales do. Even en-CA seems to work. ???
stig
(Stig Nygaard)
February 10, 2020, 9:37pm
3
It’s getting stranger…
If I enter the Install page (en-GB version) from a search result on AMO, it will initially show the Release notes. However if I then reload the Install page, the Release notes disappears from the page?..
Mine only appears to “en-CA” viewers (I am Canadian).
1 Like
jorgev
February 11, 2020, 9:25pm
5
1 Like
opened 09:04PM - 09 Feb 18 UTC
closed 03:01PM - 29 Jun 23 UTC
component:i18n
neverstale
repository:addons-server
### Describe the problem and steps to reproduce it:
* Set your locale (in the UR… L) to `en-GB`
* Submit an add-on to devhub
* Manage the version and enter in some _Version notes_ such as a list of things you changed
* Wait for auto-approval
* View the detail listing in the **en-US** locale
### What happened?
You do not see any _Release notes_ section on the page
### What did you expect to happen?
You should see the _Release notes_ containing the text from the `en-GB` locale
### Anything else we should know?
This is due to how locales works in the API. You can compare these two API requests:
```
$ curl 'http://localhost:3000/api/v3/addons/addon/sound-control/?lang=en-US' | jq .current_version.release_notes
null
$ curl 'http://localhost:3000/api/v3/addons/addon/sound-control/?lang=en-GB' | jq .current_version.release_notes
"- Changed some stuff\n- Fixed some bugs"
```
For the case where no string exists in the requested locale but we still have some string in another locale, can we fall back to it? Isn't there a concept of a default locale?
I think this is going to bite us for many things, not just version notes.
Originally reported in https://github.com/mozilla/addons/issues/11427
┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/ADDSRV-155)
@jorgev please, does it also need an addons-frontend
issue?