Nice work, @Risa
Regarding the line-height:
Your values are correct, but it’s recommend to use unitless values. For an explanation see: https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#prefer_unitless_numbers_for_line-height_values
To show how to calculate the line-height
let’s look at the header:
Because you used box-sizing: border-box;
we first have to subtract the padding from the height to get the height of the content: 5em - 1em - 1em = 3em (height minus top and bottom padding). Since the size of the h2 font is 2em and we want to reach the 3em from above for the resulting height, we need to choose 1.5 as the value (1.5 * 2em = 3em).
The same can be done for the footer: font-size
(1.5em) * line-height
(2) = resulting height (3em)
You hope this was understandable.
Have a nice weekend,
Michael