Assessment request-Marking up a letter

MDN Learn
#1

#2

Hi @manish_ghimire and welcome to the community :wave:

Great work on your first big exercise. :medal_sports:

Here are some remarks:

  • <address> is used for more than just the street and town. For example the name and contact details. You should replace <header> with <address>. The only thing that doesn’t belong to the address is <time>. <time> should get it’s own <p> with the sender-column class.
  • For the source of the quote on the last line we should use the <cite> element instead of <em>.
  • Everything else is correct. :slightly_smiling_face:

Have a nice day,
Michael

#3

Hello @mikoMK Thank you for your review I revised the techniques and completed the letter once again from the scratch.
Here’s the final letter.
https://codepen.io/manish-ghimire-cs50/pen/gOedyBa

once again, thank you for your help…

1 Like
#4

Great improvements, @manish_ghimire

Now everything looks fine :+1:

1 Like