Hi, can you please review my code for the Advanced Form Styling 1 skill test?
Here is my Glitch project page and here is the assessment description.
Thanks, have a nice day!
Hi @funny-monke
Very well done!
Some small remarks:
-
line-height
tends to work better thanheight
for keeping a consistent height in which the input text is vertically-centered - You should wrap the values of attribute selectors in quotes:
input[type="search"]
- Instead of
align-self: center;
on the element you could usealign-items: center;
on the form.align-self
is meant to override the defaultalign-items
value of the form.
Happy coding!
Michael
1 Like
Thanks for the feedback! I updated my code accordingly.
1 Like
Great work on the improvements!
Now it’s perfect
Michael
1 Like