Assessment wanted for Fundamental Layout Comprehension - Vlad

MDN Learn
#1

Hey there! Happy New Year! :clinking_glasses::partying_face:

Went through the CSS module and would like an assessment of my work if possible.

Live Site: https://fundamental-website-layout.glitch.me

Code: https://glitch.com/edit/#!/fundamental-website-layout

Mozilla Assessment Page: https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Fundamental_Layout_Comprehension

As an extra, I tried making it responsive using Responsive Web Design via Media Queries.

How does it look? Any recommendations?

Thank you for you’re time and due diligence!

#2

Howdy @Vladlen_Vronsky

Great work! I like how you went the extra mile with the media query. :heart_eyes:

You have a lot of duplicated props in the media query. When you use media queries you would just write new or changed props. The “normal” CSS from above still applies. So no need to repeat it.

I hope that helps. :slightly_smiling_face:
Michael

1 Like
#3

Awesome! Thank you so much for the help and review. Onward and upwards!

1 Like