Assessment wanted for JSON skill test-1

[ashwinsoni86 (Ashwin Soni)]

Hi, I would like my work assessed.

link to the assessment: https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Test_your_skills:_JSON#json_1

link to my Codepen: https://codepen.io/ashwinsoni86/pen/wvyWNxL

thanks in advance!!

[mikoMK (Michael Koch)]

Hi @ashwinsoni86 and sorry for the long waiting time

Nice work on this exercise!

Here are some comments:

• Try to use consistent indention for better readability. Check out the differences when you hit “Format JavaScript” in CodePen.
  
  
• I would prefer “dot notation” over “bracket notation” where possible:

  /* harder to read */
  catObj[i]["name"]
  /* easier to read */
  catObj[i].name
  

• Since we don’t need the index inside the inner loop, we could make it easier by using for..of:

  for (const kitten of catObj[i].kittens) { ... }
  

• You used total++; in if and else. You could just put it outside the if...else condition once.

Feel free to ask questions if something is unclear.

Happy coding,
Michael

[ashwinsoni86 (Ashwin Soni)]

Thanks @mikoMK for the feedback. I will definitely work on them.