Assessment wanted for "Marking up a letter" | dissidenttux

MDN Learn
,
1

I wish for feedback on my attempt at Assessment: Marking up a letter. Any requirements I missed? Anything I could have done better?

Here is my source code:

Thank you in advance for contributions and time.

"Marking up a letter" assessment
2

Hi @dissidenttux

Nicely done!
Here are some comments:

  • No need for the <p> inside <address>.
  • Self-closing elements don’t need /> (e. g. <br> is okay).
  • You can omit the last <br> in the address since it automatically breaks the line.
  • The first <address> and the <p> with the date should have a class attribute with value “sender-column” to align them to the right.
  • Everything else looks fine :slightly_smiling_face:

Have a nice day,
Michael

1 Like
3

Input taken and adjusted, thanks for the critique!

1 Like