Assessment wanted ( for Structuring a page of content )

MDN Learn
#1

Hello,
just starting learning HTML. Please assess my second work. Thank you.

Assessment page: Structuring a page of content
My implementation: CodePen

#2

Hi @deodede

Well done! Here are two comments:

  • What is the reasoning for the wrapper <div>?
  • I would remove the <section> in the <footer>. The <p>s are already grouped by the <footer> and we normally use <section> for texts with headings (e. g. every comment in a comment area on a page).

Have a nice day,
Michael

PS: Your email address is visible in your post. It ended up in the optional “name” field of your profile. I recommend removing it.

#3

Hi Michael
Thank you for your insights. Here are response to your comments:

  • There was an instruction in a project brief to create wrapper so I did.
  • CSS was provided in this task ( The provided CSS is designed so that when the correct structural elements are added to the markup, they will appear green in the rendered page ). By adding <section> element to the <footer> I made <footer> appear green.

P.S. Thank you for the note about email. Will try to fix it.

#4

Thanks for the feedback. Now, I understand. When the task description says:

You need to add a suitable wrapper for:
The header
The navigation menu
The main content
The welcome text
The image sidebar
The footer

They mean individually for every part. <nav> is a wrapper for “The navigation menu” and so on. Not a wrapper around all of them.

When you remove your <div id="wrapper">, you will see how the red border disappears. Then you can also remove the <section> in the footer without it getting red.