Assessment wanted for "Styling a biography page" | dissidenttux

Assessment wanted for “Styling a biography page”

Looking for feedback on the HTML assessment Styling a biography page.

Just wanted to check if there is anything out of place or not, or simply document my success. I ran my HTML through the W3C validator (HTML & CSS) and seemed to have cleared everything. Here is my source code, validate at will.

Thanks in advance,
dissidenttux

My code (on CodePen):

HTML

<!doctype html>
<html lang="en">

  <head>
    <meta charset="utf-8">
    <title>Formatting a biography</title>
    <link rel="stylesheet" type="text/css" href="style.css"/>
  </head>

  <body>

    <h1>Jane Doe</h1>
    <div class="job-title">Web Developer</div>
    <p>Far far away, behind the word mountains, far from the countries Vokalia and Consonantia, there live the blind texts. Separated they live in Bookmarksgrove right at the coast of the Semantics, a large language ocean.</p>

    <p>A small river named Duden flows by their place and supplies it with the necessary regelialia. It is a paradisematic country, in which roasted parts of sentences fly into your mouth.
    </p>

    <h2>Contact information</h2>
    <ul>
      <li>Email:
        <a href="mailto:jane@example.com">jane@example.com</a>
      </li>
      <li>Web:
        <a href="http://example.com">http://example.com</a>
      </li>
      <li>Tel: 123 45678</li>
    </ul>

  </body>

</html>

CSS

body {
  background-color: #fff;
  color: #333;
  font-family: Arial, Helvetica, sans-serif;
  padding: 1em;
  margin: 0;
}

h1 {
  color: hotpink;
  font-size: 2em;
  font-family: Georgia, 'Times New Roman', Times, serif;
  border-bottom: 10px dotted purple;
}

h2 {
  font-size: 1.5em;
  font-style: italic;
}

h2 + ul {
  background-color: #eeeeee;
  border: 5px solid purple;
  padding: 2rem;
}

.job-title {
  color: #999999;
  font-weight: bold;
}

a:link,
a:visited {
  color: #fb6542;
}

a:hover {
  text-decoration: none;
  color: green;
}

Hi @dissidenttux

This looks very good. Just one thing: It may be better to style visited and non-visited links in different colors.

Cheers,
Michael

1 Like