Assessment wanted for Test your skills: CSS and JavaScript accessibility

[Risa]

Hi! Could someone kindly check my work on Test your skills: CSS and JavaScript accessibility?

Thank you!

My work
CSS1

CSS2

JS1

Test page

Test your skills: CSS and JavaScript accessibility - Learn web development | MDN

[mikoMK (Michael Koch)]

Hi @Risa

Here are my comments:

• Task 1: Nice styles! I like how you made :focus more prominent than :hover.
• Task 2: Great improvements! Another strong argument against vw for font-size is that the text isn’t zoomable by the user. ( WCAG 1.4.4 (AA) states that text should be resizable.)
  The only acceptable way to use vw would be in combination with other units. For example: font-size: calc(1.5vw + 1rem); (Changes with screen size, but is always larger than 1rem)
• Task 3: When using the focus event you can remove the other event. Another solution would be to use the keyup event and test for the “Enter” key to have a slightly different behavior.

Overall, very well solved exercises. Congratulations!

See you,
Michael

[Risa]

Hi @mikoMK,

Thank you for your feedback and sorry for my late reply!

@mikoMK

• Task 2: Another strong argument against vw for font-size is that the text isn’t zoomable by the user.
  The only acceptable way to use vw would be in combination with other units. For example: font-size: calc(1.5vw + 1rem);

Oh I see, I didn’t realise! Thank you so much

@mikoMK

• Task 3: When using the focus event you can remove the other event. Another solution would be to use the keyup event and test for the “Enter” key to have a slightly different behavior.

I tried the alternative version using keyup event. Thank you!

[mikoMK (Michael Koch)]

Nice!