Can't locate some UI strings

Razmik-Badalyan · August 23, 2022, 3:11pm

Couldn’t find “Cancel”, “Custom goals” and “of daily goal”, in the Georgian translation project.

Found “Yes” and “Listen”. There are translated, but, as you can see, there are in English on the site.

bozden · August 23, 2022, 9:27pm

I see you have been translating recently, and you only have one unreviewed. But, even if they all get accepted, they do not directly come out to the actual website. They come out with the next website release.

Did you check the development and/or staging area?

Staging: https://commonvoice.allizom.org/ka
Development: https://dev.commonvoice.allizom.org/ka

Razmik-Badalyan · August 24, 2022, 5:51am

Hi @bozden,

I couldn’t check on neither of those, because these texts are on the profile and there is no profile page on Staging or Development; can’t log in.

bozden · August 24, 2022, 4:04pm

Then, current release is:

Last-Modified: Wed, 17 Aug 2022 16:04:34 GMT

Anything accepted after that will be on the next release I think…

Razmik-Badalyan · August 24, 2022, 4:18pm

I have seen this English strings long time ago, and the Georgian project has been 100% translated for a while now. Just checked the Russian site, same issue there.

bozden · August 24, 2022, 4:34pm

Right, same in Turkish…

Would you open an issue on github for these?

bozden · August 24, 2022, 4:40pm

Found the culprit, one of them at least, others should be around:

github.com

common-voice/common-voice/blob/main/web/src/components/pages/dashboard/goals/custom-goal-steps.tsx#L57


  locale,
  onNext,
  customGoal: { amount, current, days_interval },
}: {
  locale: string;
  onNext: () => any;
  customGoal: CustomGoal;
}) => (
  <div className="padded view-goal">
    <div className="top">
      <h2>Custom Goals</h2>
      <button className="edit-button" type="button" onClick={onNext}>
        <PenIcon />
      </button>
    </div>
    {Object.keys(current).map(key => {
      const value = (current as any)[key];
      return (
        <div key={key} className={'goal-box ' + key}>
          <Fraction numerator={value} denominator={amount} />

Edit: Second one here…

github.com

common-voice/common-voice/blob/main/web/src/components/pages/dashboard/goals/custom-goal-steps.tsx#L71


</div>
{Object.keys(current).map(key => {
  const value = (current as any)[key];
  return (
    <div key={key} className={'goal-box ' + key}>
      <Fraction numerator={value} denominator={amount} />

      <div className="relative">
        <CircleProgress value={value / amount} />
        <div className="interval">
          {days_interval == 7 ? 'Of weekly goal' : 'Of daily goal'}
        </div>
      </div>

      <LinkButton
        className="cta"
        rounded
        absolute
        to={'/' + locale + (key == 'speak' ? URLS.SPEAK : URLS.LISTEN)}>
        {key[0].toUpperCase() + key.slice(1)}
      </LinkButton>

heyhillary · August 25, 2022, 1:18pm

Thanks for supporting this query !

bozden · August 25, 2022, 2:09pm

Posted an issue on github, probably will be taken care of after holidays

github.com/common-voice/common-voice

[BUG] Wording without i10n on dashboard/goals page

opened 02:06PM - 25 Aug 22 UTC

HarikalarKutusu

Bug Good First Issue Unlocalised string

**Describe the bug** It is reported that there are some wordings that do not go… through localization. Please look at the following Discourse post for screenshots: https://discourse.mozilla.org/t/cant-locate-some-ui-strings/103752/8 **To Reproduce** Steps to reproduce the behavior: 1. Use a non-English setting, login and go to dashboard/goals/your language page (should be non-English) 2. Check the screenshots on the post E.g.: https://commonvoice.mozilla.org/tr/dashboard/tr/goals **Additional context** Found two of them in the code, their locations are also in that Discourse post.