HTML5 Controls 1 and 2

MDN Learn
#1

Hi there :slight_smile:

Hope you’re well.

Kindly asking for review/assessment of my markup. Link here.

Thank you in advance :slight_smile:

#2

Hey @Phil_G

Great work! :tada:

The controls themselves are all fine, but I have two general remarks:

  • <div>s as direct children of <ul> aren’t valid HTML. You should change them to <li>.
  • Trailing slashes on void elements (elements without an end tag) should be avoided. It’s something that was necessary a long time ago and we still see examples on the web using them.

I hope that helps.
Michael

1 Like
#3

Thanks @mikoMK - yeah I think I’m one of those stuck in the past that thought you still had to include trailing slashes. Time to re-condition :+1: :laughing:

1 Like