Is it alright with this add-on to pass admin reviewing?

Add-ons addons.mozilla.org
1

Hello everyone!
I’ve got my add-on in the admin queue and it won’t be reviewed soon, so I don’t want to get a rejection and get the add-on in the end of this long queue again.
Could you, please, take a look at my add-on before it reaches reviewer, and describe possible drawbacks of it that could lead to rejection?

Link to the AMO page: https://addons.mozilla.org/ru/firefox/addon/leo-translate/
Source code: https://github.com/mdnsk/leo-translate

2

web-ext lint:
Validation Summary:
errors 0
notices 0
warnings 9

MANIFEST_CSP
DANGEROUS_EVAL

3

Thank you for reply!
I’ve solved this problem.
web-ext lint still shows 5 warnings related with eval, but anyway eval will not execute because I’ve removed unsafe-eval permission from manifest.json

4

That depends… if the script is injected into a page, then it is a different story.

The minified code makes it difficult to advise.

5

I’ve cleaned the code of all the evals, so now web-ext lint displays no warnings.
And I’ve also disabled minification of the compiled code, but it does not seem to be more readable because it contains a lot of the webpack’s stuff, transpiled es6 expressions and compiled vue components :confused: