"Mozilla splash page" assessment

[filip.sky]

Hi anyone could give me feedback,please

Mozilla splash page /* header and body setup */

  html {
    font-family: 'Open Sans', sans-serif;
    background: url(pattern.png);
  }

  body {
    width: 100%;
    max-width: 1200px;
    min-width: 360px;
    margin: 0 auto;
    background-color: white;
    position: relative;
  }

  /* Header styling */

  header {
    height: 150px;
  }

  header img {
    width: 100px;
    position: absolute;
    right: 32.5px;
    top: 32.5px;
  }

  h1 {
    font-size: 50px;
    line-height: 140px;
    margin: 0 0 0 32.5px;
  }

  /* main section and video styling */

  main {
    background: #ccc;
  }

  article {
    padding: 20px;
  }

  h2 {
    margin-top: 0;
  }

  p {
    line-height: 2;
  }

  iframe {
    float: left;
    margin: 0 20px 20px 0;
    max-width: 100%;
  }

  /* further info links */

  .further-info {
    clear: left;
    padding: 40px 0;
    background: #c13832;
    box-shadow: inset 0 3px 2px rgba(0,0,0,0.5),
                inset 0 -3px 2px rgba(0,0,0,0.5);
  }

  .further-info a {
    width: 25%;
    display: block;
    float: left;
  }

  .further-info img {
    max-width: 100%;
  }

  .clearfix {
    clear: both;
  }

  /* Red panda image */

  .red-panda img {
    display: block;
    max-width: 100%;
  }
</style>

Mozilla

</header>

<main>
  <article>
    <!-- insert iframe from youtube -->
    <iframe width="400" height="315" src="https://www.youtube.com/embed/ojcNcvb1olg" frameborder="0" allowfullscreen></iframe>
    <h2>Rocking the free web</h2>

    <p>Mozilla are a global community of technologists, thinkers, and builders, working together to keep the Internet alive and accessible, so people worldwide can be informed contributors and creators of the Web. We believe this act of human collaboration across an open platform is essential to individual growth and our collective future.</p>

    <p>Click on the images below to find more information about the cool stuff Mozilla does. <a href="https://www.flickr.com/photos/mathiasappel/21675551065/">Red panda picture</a> by Mathias Appel.</p>
  </article>

  <div class="further-info">
    <!-- insert images with srcsets and sizes -->
    <a href="https://www.mozilla.org/en-US/firefox/new/">
      <img srcsets="firefox_logo-only_RGB120w.png 120w,
                    firefox_logo-only_RGB400w.png 400w"
           size="(max-width:480px) 120px,
                 (min-width:481px) 400px"
           src="firefox_logo-only_RGB400w.png" alt="Mozila logo new">
    </a>
    <a href="https://www.mozilla.org/">
      <img srcsets="firefox-addons120w.jpg 120w,
                    firefox-addons400w.jpg 400w"
           size="(max-width:480px) 120px,
                 (min-width:481px) 400px"
           src="firefox-addons400w.jpg" alt="Mozila logo old">
    </a>
    <a href="https://addons.mozilla.org/">
      <img src="mdn.svg" alt="new logo">
    </a>
    <a href="https://developer.mozilla.org/en-US/">
      <img srcsets="mozilla-dinosaur-head120w.png 120w,
                    mozilla-dinosaur-head400w.png 400w"
           size="(max-width:480px) 120px,
                 (min-width:481px) 400px"
           src="mozilla-dinosaur-head400w.png" alt="Mozila logo developer">
    </a>
    <div class="clearfix">
      </div>
  </div>

  <div class="red-panda">
    <!-- insert picture element -->
      <picture>

</main>

[chrisdavidmills]

Hi anyone could give me feedback,please

Mozilla splash page

Again, for the “Mozilla splash page” I’d like to invite you to check against the marking guide, and our finished example:

• https://github.com/mdn/learning-area/tree/master/html/multimedia-and-embedding/mdn-splash-page-finished
• https://github.com/mdn/learning-area/blob/master/html/multimedia-and-embedding/mdn-splash-page-finished/marking-guide.md
• https://mdn.github.io/learning-area/html/multimedia-and-embedding/mdn-splash-page-finished/

[jaysand]

Okay, thank you for the clarification!! Appreciate it.

[jag]

good question I can see why that could be a bit nebulous