Optional_permissions - missing `browserSettings` compatibility


(Juraj Masiar) #1

Hello,

The MDN page for optional_permissions is missing compatibility for browserSettings permission. How do find out the compatibility (for Firefox) and in general, what to do in cases like this? Is there a common place to report it? I would modify the MDN page myself if knew the answer…

EDIT: ok I just found the bugzilla page “Make browserSettings an optional permission” which was fixed in 57 - I think this is the answer I was looking for (please correct me if I’m wrong or my approach can be improved).


(Martin Giger) #2

Compatibility tables can be modified by changing the data in https://github.com/mdn/browser-compat-data and I think the one for optionalPermissions was added after that permission was enabled for optionalPermissions.

Also, looking for the bugs is the correct way to find out when something was added in Firefox.


(Juraj Masiar) #3

Thank you for the link! I totally forgot these are not part of the MDN.

Any idea how to fill the other browsers data? I’m not so eager to spend my time checking Edge compatibility… will it be too much if I just create issue for that? :smiley:


(Martin Giger) #4

Pretty sure only Firefox supports that permission in the first place (see the non-optional version).


(Juraj Masiar) #5

What a superior browser!
Thank you for your help. I will make the pull-request then.

EDIT: if somebody is interested in a pull-request:


(what a cool integration with GitHub!)


#6

Thanks for the PR! As a general point: it’s fine to not check other browsers for compat if you can’t or don’t want to. Just put null, which means "unknown. But in this case, yes, false is right for other browsers.