webRequest.onCompleted event stops working until after restarting

jdorw · September 8, 2017, 2:54pm

I’ve been getting bug reports of our extension acting weird when a user is upgraded to a new version. I’ve been able to isolate it to a problem with the webRequest.onComplete event.

The problem is that the event stops firing until the browser has been restarted. After restarting the event works as expected.

Any idea why this happens or do I need to tell users to restart after an upgrade?

Here’s where I’m using that event:

github.com

duckduckgo/chrome-zeroclickinfo/blob/beta/js/tabManager.js#L125


}


});


chrome.runtime.onMessage.addListener( (req, sender, res) => {
if (req.whitelisted) {
    tabManager.whitelistDomain(req.whitelisted)
    chrome.runtime.sendMessage({whitelistChanged: true});
}
else if (req.getTab) {
    res(tabManager.get({'tabId': req.getTab}))
}
else if (req.getSiteScore) {
    let tab = tabManager.get({tabId: req.getSiteScore})
    res(tab.site.score.get())
}
return true;
})


// message popup to close when the active tab changes
chrome.tabs.onActivated.addListener(() => chrome.runtime.sendMessage({closePopup: true}))

jorgev · September 12, 2017, 11:25am

Please file a bug report for this. Attaching a test case would help figure this out faster.