What's typical etiquette for collaborating on a MozReview patch?

(Ethan Glasser-Camp) #1

I’ve been following https://reviewboard.mozilla.org/r/54584/. The patch’s author mentioned me and gave me a task to work on. I think I have something working. How should I add it to this review? Do I amend his commit, push another commit, open another review, or something else entirely?

(Ethan Glasser-Camp) #2

I ended up asking in the mozreview channel on IRC, and what I heard was it’s not possible to “piggy-back” on someone’s existing review request. I can create a new review request, either with the existing commits and mine as followups, or with amended commits.