I would like to get some feedback for an add-on that I recently built. I couldn’t find a category that suits this kind of question/topic. Is there a place to promote and/or collect feedback for add-ons in this forum?
Congrats on the add-on! The Add-ons category feels to me like the best fit for this kind of discussion.
I took a brief look at the source and gave it a spin. I didn’t see any notable issues and the source was very nicely organized. I could only think of one potential concern (data loss on navigating to the block page), but using window.location.href navigate as you do triggers any beforeunload event handlers, so you’re solid. Nice work!
Thanks for the feedback and that you took the time to look into the add-on @dotproto ! I tried to preserve history when navigating to the blocked page, but I need to check whether it works in all scenarios (entering a blocked page from a blank page vs. navigating to a blocked page from another page). Anyhow, once again thanks for the feedback!
Allow browsers have implemented interventions to prevent back button abuse. This WebKit bug 233876 is a good entry point if you want to go spelunking on that effort.
If you want to preserve the original page’s history entry, you can use window.location.href = ... or window.location.assign(...) instead of window.location.replace(...) in your content script to initiate the navigation to your block page.