Assessment: Fundamental CSS comprehension

Hey guys, I would really appreciate an assessment on this:

Task: https://developer.mozilla.org/en-US/docs/Learn/CSS/Building_blocks/Fundamental_CSS_comprehension#starting_point

My Solution: https://codepen.io/Dominicode/pen/VwQeONJ

1 Like

Hi @why_not_phoenix and welcome to the community!

Congratulations! Very good job. I like how you added the header-footer class to make the selector easier.

I have just one little improvement. It’s generally preferred to use unitless line-height values. See this example for the reason why:
https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#prefer_unitless_numbers_for_line-height_values

I hope that helps. :slightly_smiling_face:

Have a nice day,
Michael

2 Likes

Thanks @mikoMK.
I checked it out the link for your suggestion. Thanks for the help, I really appreciate.

1 Like