Hello, new to mozilla discourse. I think i did okay on this, want to know if my css may need some tidying up.
Link to my code: https://codepen.io/kofi-kay/pen/bGjevJJ
Hi @kofikay162 and welcome to the community
You did indeed.
I have just two small comments:
- It’s recommended to use unitless numbers for
line-height
. For an explanation see: https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#prefer_unitless_numbers_for_line-height_values - The
line-height
in the footer should be2
. This will lead to a paragraph height of3em
, that will center the text vertically. (1.5em * 2 = 3em = height of footer).
I hope that helps
See you,
Michael
I’ve made the changes thank you.
1 Like
Now it’s perfect!
PS: Your email address is visible in your post. It ended up in the optional “name” field of your profile. I recommend removing it.
Oh! thanks for the heads up
1 Like