Assessment wanted for A cool-looking box-haydee

MDN Learn
1

task page

my work page

I have a question about line-height
In this pracitce, I set the line-height at 50px which is the height of the content box since I am using the default box model. I ignored padding at this point. am I right?

2

Hello @Austin_Hart

Great job! That’s a cool-looking box :grin:

Some comments:

  • You can omit height when using line-height on buttons (and input fields), but it’s preferred to use a unitless values instead of px. It’s a multiplier of the font size when used this way. So a good value for this exercise would be line-height: 3;.
  • You correctly used and described rem. Since we want a slightly increased font size, maybe 1.1rem would be a better choice.

Just ask if something is unclear :slightly_smiling_face:

Cheers,
Michael

3

thank you for your comment, I used a unitless line-height and it’s much better :smiley:

1 Like