Assessment wanted for Basic controls 1, 2 & 3 skill tests

Link to task-


Link to my code-
TASK 1-https://jsfiddle.net/shivani0005/uytgqo14/1/
TASK 2-https://jsfiddle.net/shivani0005/uytgqo14/
TASK 3-https://jsfiddle.net/shivani0005/ohk819xe/8/

Thanks

Hi @S005 and welcome to the community :wave:

Great work on these tasks! :medal_sports:

Here are my comments:

  • Task 1: :white_check_mark: Correct.
  • Task 2: :warning: Nearly correct. You have a double </li> on lines 43 and 44. The actual form controls are correct.
  • Task 3: :warning: Nearly correct. We want only JPG and PNG to be allowed and not all image types. So we should use accept="image/png, image/jpeg"

I hope that helps.
Michael

1 Like

Thanks for your feedback @mikoMK. I have made changes according to the suggestion provided by you. I also came to know I have pasted task 2 link wrong, so here is the updated link for task 2-https://jsfiddle.net/shivani0005/f8j20pbs/18/

Task 2 and 3 are correct now. :clap:

For task 3 be aware that a mime type may also include some lesser used file extensions. For example image/jpeg also includes .jpe, but I would say most of the time this isn’t really relevant.