Assessment wanted for Fundamental Layout Comprehension~

MDN
#1

Hello,

I would like some feedback on my site for the Layout Comprehension assessment.

My website is live on GitHub Pages and the source code is in this repo.

I enjoyed this project learning about CSS layout. Please let me know how I can improve :star:

#2

Hi @s-zavala

Amazing work on this task! :clap:

Only some minor things:

  • A bit of grid-gap between article and aside would be nice.
  • If a value has zero length you can just omit the unit: top: 0px; :arrow_right: top: 0;
  • If you remove flex: 1; the nav would look more balanced in my opinion.

That’s all! I hope it’s helpful.

All the best,
Michael

1 Like
#3

Thank you for this feedback!

The navigation bar looks much better without flex: 1;.

1 Like