Assessment wanted for Marking up a letter from Kinjal

MDN Learn
1

Hello Everyone,
I just completed the marking up a letter assignment and would like it to be assessed.
https://jsfiddle.net/koraavo/zLdo580w/3/

I hope I am doing it the right way in sending it over to you. :blush:

Regards,
Kinjal

2

Hello @Kinjal and welcome to the community :wave:

You did a great job on this exercise. Congratulations! :medal_sports:

Here are some comments:

  • On the first address you can put class="sender-column" directly on the <address>. No need for the additional <p>.

  • The <em>s inside the <address>es are not necessary since <address> already makes everything italic and emphasis isnā€™t necessary.

  • You missed this subtask:

    The four dates in the document should have appropriate elements containing machine-readable dates.

    Do you know which element you could use to achieve this?

  • The motto ā€œBe awesome to each other.ā€ should be wrapped in <q> tags since it is a quote.

  • Thereā€™s a stray end tag on line 110 (</p>)

I think thatā€™s about it. As you see, only some small things, nothing bad. Keep up the good work! :slightly_smiling_face: Feel free to come back with more tasks or questions.

Have a nice day,
Michael

1 Like
3

Hey Michael,

Thanks for all the suggestions.
I used the time tag with the date time for the dates, and got rid of the em tags for emphasis in the addresses. Used the quotes and I think in terms of HTML it definitely seems better :slight_smile:
Thanks again for the quick feedback.
I shall start working on the next one after work and post it for assessment as well :slight_smile:

Regards,
Kinjal

1 Like
4

Hi Michael,

Happy new Year!
Every time I try to post something I get an error message saying I cannot post a link to that post? Is there a restriction or am I doing something wrong here?

I was trying to post the assessment for videos and embed and iframe exercises.

Regards,
Kinjal

1 Like
5

Hello Kinjal,

Thank you very much. I wish you a happy new year, too!

It looks like someone has flagged both of your previous topics for whatever reason. They appear as ā€œThis post was flagged by the community and is temporarily hidden.ā€ for me. This makes absolutely no sense! :angry: I will contact the moderators team about it.

Meanwhile, you could try to post your new tasks here in this thread.

Sorry for the inconvenience. I hope the mods can sort this out.

Michael

Edit: I contacted the mods to unblock you.

1 Like
6

Hi Michael,
I tried posting another today in this thread. It is not accepting them at all. I am unable to share the assessment. Is there any other way I can share it?

Regards

7

I have thought of an idea. Maybe I embed it :slight_smile:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Document</title>
</head>
<body>

<script async src="//[jsfiddle.net/koraavo/n1y6oajL/5/embed](http://jsfiddle.net/koraavo/n1y6oajL/5/embed)/"></script>

</body>
8

Nice idea with using embedding :slightly_smiling_face: Probably an easier way would have been to just post the link with backticks at start and end. So it doesnā€™t appear as a link. Like this:

`http://jsfiddle.net/koraavo/n1y6oajL/5`

But hey, if it works, it works :grin: Here are my comments:

  • The video part is correct, but your paragraph about lacking browser support ended up at the very end of your code. It should go inside the <video> element.
  • For the PDF embedding you should use width and height attributes to control the size of the element.
  • When embedding a Youtube video with an <iframe> you canā€™t use the sandbox attribute. It needs to be delete to make the video work.

I hope that helps! :sweat_smile:

All the best,
Michael

9

Thanks Michael for the feedback. So I can just convert the whole thing as a string, so it does not show like a link. Got it!

Tell me again when to use sandboxing generally? because the text mentioned always use sandbox, maybe with a parameter. Currently I think it is just sandbox and not sandbox="".
Let me look at the rest of the code and just correct them anyway :slight_smile:

Thanks again for the feedback :slight_smile:

1 Like
10

Tried to send the Splash assignment, it did not show it the way I desired it :stuck_out_tongue:

Document

Sending it over here again!

Thanks so much Michael for your feedback so far. Kommst du aus Dland?

Regards,
Kinjal

1 Like
11

Generally it is a good idea to use sandbox whenever possible. This restricts the permissions an <iframe> has. Because an embedded YouTube video needs some permissions to work, you could use sandbox="allow-scripts allow-same-origin" to make it work by weakening those restrictions. I guess a weakened sandbox is still better than no sandbox at all, but Iā€™m not experienced enough with this topic to exactly tell you how much better in this specific scenario. :neutral_face:

This is what I see in your latest post where you tried to embed your newest work (same for your new topic). Did you try to just use backticks around the link as I recommended above? It seems that you posted your new work via email. Maybe trying to login to this forum in the browser and try posting it directly could help.

Unfortunately I havenā€™t heard from the mods regarding your block :frowning_face:

No, Switzerland. Just south of Germany. But we also talk (kind of) German. :stuck_out_tongue: Itā€™s a German dialect that is very different from Standard German.

Cheers,
Michael

12

Hahaha. I do understand the Swiss German dialect but cannot speak it hahahā€¦
I am planning to anyway send the table assignment in some time, let me try to do it via the ticks method and see if that works. I usually get the embed option in jsriddle or glitch, so I make no changes to it and just put it inside an HTML document :slight_smile:

Ich arbeitete bei Western Digital als Kundenberater, und es gab viele Schweizer, die uns angerufen haben. Es gibt so viele von denen, die noch Windows XP verwenden. I was really surprised and tired to help them use their external hard disk on a dead OS :stuck_out_tongue:

Freut mich dich kennenzulernen :slight_smile:

1 Like
13

Hehehe. Nicht viele Menschen ausserhalb der Schweiz kƶnnen uns verstehen :sweat_smile:

:switzerland: Ich wĆ¼nsch der alles Gueti und freut mi au dich kƤnnezlernƤ! :switzerland: