Assessment wanted for Marking up a letter ^_^

MDN Learn
,
#1

Hi everyone,

I would appreciate some feedback on my source code: Marking up a letter Codepen.

I am having difficulty with nested tags, but using W3C HTML Validator helped catch some syntax errors.

This is the assessment page.

Thank you! :smiley:

#2

Hi @s-zavala and welcome to the community :wave:

Congratulations! You have done a great job :tada:

Some small improvements:

  • There is no need for <p> inside <address> to rewrap the whole content again. The class can be set directly on the <address> tag.
  • <br> after the first date is not necessary because the <p> (as a block element) automatically breaks the line.
  • The links are missing title attributes

Everything else is perfect! :slightly_smiling_face:

You are right. The HTML validator is a great tool. Sometimes we make mistakes but the page still looks correct, because browsers are very good at correcting them automatically. But then you change something else and suddenly it breaks the page.

If you have any questions or another task, feel free to ask. Iā€™m happy to help!

Happy coding!
Michael

#3

Thank you for the warm welcome and helpful feedback!

I will fix the unnecessary <p> and <br> and add title attributes to my links.

Have a great week :smiley:

1 Like
#4

Yep, now it looks flawless :+1: