Assessment wanted for "Mozilla Splash Page"

Hello!

I have completed the test of "Mozilla Splash Page’ and would like to be assessed.

the art-directed image (red panda) doesn’t seem to work. But I don’t think I’ve done anything wrong :frowning:

Find the - [MDN Pages] of the project(https://arittra.github.io/mozilla-spalsh-page/)

Code - `

Mozilla splash page /* header and body setup */
  html {
    font-family: 'Open Sans', sans-serif;
    background: url(pattern.png);
  }

  body {
    width: 100%;
    max-width: 1200px;
    margin: 0 auto;
    background-color: white;
    position: relative;
  }

  /* Header styling */

  header {
    height: 150px;
  }

  header img {
    width: 100px;
    position: absolute;
    right: 32.5px;
    top: 32.5px;
  }

  h1 {
    font-size: 50px;
    line-height: 140px;
    margin: 0 0 0 32.5px;
  }

  /* main section and video styling */

  main {
    background: #ccc;
  }

  article {
    padding: 20px;
  }

  h2 {
    margin-top: 0;
  }

  p {
    line-height: 2;
  }

  iframe {
    float: left;
    margin: 0 20px 20px 0;
    max-width: 100%;
  }

  /* further info links */

  .further-info {
    clear: left;
    padding: 40px 0;
    background: #c13832;
    box-shadow: inset 0 3px 2px rgba(0,0,0,0.5),
                inset 0 -3px 2px rgba(0,0,0,0.5);
  }

  .further-info a {
    width: 25%;
    display: block;
    float: left;
  }

  .further-info img {
    max-width: 100%;
  }

  .clearfix {
    clear: both;
  }

  /* Red panda image */

  .red-panda img {
    display: block;
    max-width: 100%;
  }
</style>

Mozilla

</header>

<main>
  <article>
    <!-- insert iframe from youtube -->
    <iframe width="400" 
    src="https://www.youtube.com/embed/ojcNcvb1olg" 
    frameborder="0" 
    allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" 
    allowfullscreen></iframe>

    <h2>Rocking the free web</h2>

    <p>Mozilla are a global community of technologists, thinkers, and builders, working together to keep the Internet alive and accessible, so people worldwide can be informed contributors and creators of the Web. We believe this act of human collaboration across an open platform is essential to individual growth and our collective future.</p>

    <p>Click on the images below to find more information about the cool stuff Mozilla does. <a href="https://www.flickr.com/photos/mathiasappel/21675551065/">Red panda picture</a> by Mathias Appel.</p>
  </article>

  <div class="further-info">
    <!-- insert images with srcsets and sizes -->
    <a href="https://www.mozilla.org/en-US/firefox/new/">
      <img srcset="firefox_logo-only_rgb120.png 120w,
                   firefox_logo-only_rgb-400.png 400w"
           sizes="(max-width: 500) 120px,
                  400px "
           src="firefox_logo-only_rgb-400.png"
           alt="The shiney new Firefox logo">
    </a>
    <a href="https://www.mozilla.org/">
      <img srcset="mozilla-dinosaur-head120.jpg 120w,
                   mozilla-dinosaur-head400.jpg 400w"
           sizes="(max-width: 500) 120px,
                  400px "
           src="mozilla-dinosaur-head400.jpg"
           alt="The Mozilla dinosaur head logo">
    </a>
    <a href="https://addons.mozilla.org/">
      <img srcset="firefox-addons120.jpg 120w,
                   firefox-addons400.jpg 400w"
           sizes="(max-width: 500) 120px,
                  400px "
           src="firefox-addons400.jpg"
           alt="The Mozilla addons logo">
    </a>
    <a href="https://developer.mozilla.org/en-US/">
      <img src="mdn.svg">
    </a>
    <div class="clearfix"></div>
  </div>

  <div class="red-panda">
    <!-- insert picture element -->
    <picture>
      <source media="(max-width: 600)" src="red-panda600.jpg">
      <source media="(min-width: 601)" src="red-panda1200.jpg">  
      <img src="red-panda1200.jpg" alt="A lovely red panda">
    </picture>
  </div>

</main>
`

Hello @Arittra

you doing great

you need to use srcset not src and also give unit to the width so 600px not just 600

and for your meta you missed the initial-scale

<meta name="viewport" content="width=device-width, initial-scale=1">

it would be nice if you include a link to the topic in your future post
hope that help and have a nice day :slight_smile:

Thanks a lot!
The problems are fixed now, great!

you very welcome :slight_smile: