Assessment wanted for my Marking up a letter

Hello! I have done the skill test for Marking up a Letter. Kindly check my code and review.

Looking forward to your response :slight_smile:

Quick Question
Why does the address at the bottom is aligned to the left while mine is aligned to the right?

Thank you

Congratulations, @tuhamworld!
Nearly everything is correct. :clap:

Here are my comments:

  • You don’t need <p> inside <address>. You can put the class directly on the <address>.
  • <time> isn’t part of the address and should go into its own <p> after <address>.

You used the “sender-column” class on it which aligns text to the right side. This would be fine:

<p>Yours sincerely,</p>
<p>Dr Eleanor Gaye</p>

I think that’s all. As you see, only some small things. :slightly_smiling_face:

Have a nice weekend,
Michael

2 Likes

Hello @tuhamworld and @mikoMK

just a little extend to what @mikoMK said that you will get to know the class and css in the css leason

and have a nice day both of you :slight_smile:

2 Likes

Thank you so much for the clarification. Now I understand.
The reason why I left the time inside the address was so - I could make it align to the right.

What I did next was to use another <div> class for time - and everything appears fine.

Can you please check again if am good to go? :grinning:

2 Likes

Thank you @justsomeone :slight_smile:

I look forward to relearning css.
Do have a nice day too

2 Likes

you very welcome and thanks a lot @tuhamworld

2 Likes

Yeah! That’s the correct way. :clap:

The <div> around <address> isn’t needed, too. This would also work:

<address class="sender-column">
  <strong>Dr. Eleanor Gaye</strong><br>
  Awesome Science faculty<br>
  University of Awesome<br>
  Bobtown, CA 99999,<br>
  USA<br>
  <strong>Tel</strong>: 123-456-7890<br>
  <strong>Email</strong>: no_reply@example.com
</address>

Keep up the good work!
Michael

2 Likes

Didn’t know I could use class for addresss too!
Thanks for this :slight_smile:

1 Like

You will learn a lot about classes in the CSS course. :slightly_smiling_face:
But yeah, you can put classes on every element.

2 Likes

That’s interesting.
Thank you for the response and insight.

See you soon :wink:
And do have a wonderful day ahead :slight_smile:

2 Likes