Hello, I would very much appreciate if my code for : Typesetting a Community School Homepage is reviewed.
Here’s my link on CodePen: https://codepen.io/tuhamworld/pen/XWEJvYw
Thank you
Hello, I would very much appreciate if my code for : Typesetting a Community School Homepage is reviewed.
Here’s my link on CodePen: https://codepen.io/tuhamworld/pen/XWEJvYw
Thank you
Well done, @tuhamworld!
Here are some small possible improvements:
a[href^="http"]
. It selects all links which href
attribute starts with “http” (no matter where they would be on the page). More on attribute selectors: https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors.width: 100%;
display: inline-block;
to the last rule. This would make the link cover the whole <li>
box.I hope that helps.
Stay safe,
Michael
Thank you for the help and kind review.
I have made those adjustments.
Could you please recheck now?
Nice work!
On the last selector you are now missing > a
. (It should target the <a>
inside <li>
- not the <li>
itself.
The rest is fine.
No wonder the link are being underlined.
I have done that just now.
Thank you
Much better. Well done!
Thank you for the review.