Assessment wanted for my "Typesetting a community school homepage"

MDN Learn
#1

Hello, I would very much appreciate if my code for : Typesetting a Community School Homepage is reviewed.

Here’s my link on CodePen: https://codepen.io/tuhamworld/pen/XWEJvYw

Thank you

#2

Well done, @tuhamworld!

Here are some small possible improvements:

  • Maybe use a different color for unvisited and visited links.
  • To make the selector for the external link icons more general, you could use the following attribute selector a[href^="http"]. It selects all links which href attribute starts with “http” (no matter where they would be on the page). More on attribute selectors: https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors.
  • You could add
    width: 100%;
display: inline-block;
    to the last rule. This would make the link cover the whole <li> box.

I hope that helps. :slightly_smiling_face:

Stay safe,
Michael

1 Like
#3

Thank you for the help and kind review.

I have made those adjustments.
Could you please recheck now?

1 Like
#4

Nice work!

On the last selector you are now missing > a. (It should target the <a> inside <li> - not the <li> itself.

The rest is fine.

1 Like
#5

No wonder the link are being underlined.

I have done that just now.

Thank you

1 Like
#6

Much better. Well done! :+1:

1 Like
#7

Thank you for the review. :slight_smile:

1 Like