Assessment wanted for "Typesetting a community school homepage"_

MDN Learn
1

Hello to whoever is reading this.
I just finished this task, need an assessment, here are my:-

Code pen link & Task link.

Thank you in Advance.

2

Again, great work on this exercise, @Dinesh_Sake! :medal_sports:

Here are some comments:

  • For the external link selector you could use something more general like a[href*="http"]. this would select any link with href starting with “http” no matter if it’s inside section p.
  • Using all: unset; is a bit too radical. For example, you also lose the hand pointer when hovering over the links. It would be better to just style the nav with nav li a and so on.
  • You could use following code to make the links in the nav fill the li. (Also remove the li padding):
nav ul li a {
  display: inline-block;
  width: 100%;
  line-height: 3;
}

I hope that helps. Feel free to ask questions. :slightly_smiling_face:

Michael

2 Likes
3

Wow! It was a completely new approach for me. I’ve made the suggested changes, you can check the code pen again if you want, and for now I’ve got no questions on top of my head. Again thanks for the insights. It was of great help to me.

1 Like
4

You made great improvements to you code. :clap:
Now the exercise is well solved. Congrats!

1 Like