Assessment wanted for Structuring planet data (Phayzor)

MDN Learn
1

Hi guys,

I would like an assessment for structuring planet data.

Here is the live page.

Here is the code.

Thanks! :slight_smile:

Fahed

2

Hi @Phayzor :wave:

Good job! Your code looks like requested. I found a few things regarding the structure:

  • You used </br>. This should just be <br>. Sometimes you see <br /> in older HTML which is also valid but not needed anymore.
  • Since we use <th> for rows and columns, it’s recommended to add scope attributes to make sure screen readers understand the structure. Example:
<tr>
  <th rowspan="2" scope="rowgroup">Ice giants</th>
  <th scope="row">Uranus</th>
  <td>86.8</td>
  ...
</tr>
  • Your <colgroup> only defines four columns. This should look like this:
<colgroup>
  <col span="2">
  <col style="border: 2px solid black">
  <col span="9">
</colgroup>

Generally it’s a good idea to run your HTML through the W3C HTML Validator to catch such small mistakes.

I hope that helps :slightly_smiling_face:

Have a nice day!
Michael

2 Likes
3

welcome back boss @mikoMK :partying_face:

1 Like
4

Hi @mikoMK,

Cheers for the advice, I really appreciate it. I have updated the code on github to reflect your changes. :slight_smile:

Fahed

1 Like
5

Thanks @justsomeone

If someone should ever be called “boss” it’s you for the endless hours you have spent helping others :confetti_ball:

6

you very welcome

and as i told you before i just let the keyboard spam the forum :joy:

and i learned a lot for you and from other people also

so thanks for you @mikoMK and for @Phayzor and for everyone :slight_smile:

2 Likes
7

Congratulations @Phayzor!
Great work on the improvements.
I just spotted a small thing I missed before. The <th>s inside <thead> aren’t wrapped with <tr>. Apart from that it’s perfect :medal_sports:

1 Like