Assessment wanted for Structuring planet data test by bedri

I kindly ask for an assessment for the structuring planet data test.

here are my codes on codepen and css provided in the test.

do appreciate for your valuable review beforehand.

Hi @bedribulut

Great job on this task! :tada:

Here are my comments:

HTML validity

  • <caption> needs to be the first child of <table>
  • When using <colgroup> we need to list all columns in <col> elements. To not having to write <col> twelve times we can use the <span> attribute. This would be valid:
    <col span="2">
    <col style="border: solid;">
    <col span="9">
    

Structure

  • The planet names (Mercury, Venus etc.) should be <th scope="row">
  • The rowspan and colspan attributes are all correct :+1:
  • The scope attributes are mostly correct with the exception of “Gas giants” and "Ice giants. Since they span two rows they should be scope="rowgroup"

Aaaaaand that’s it! :slightly_smiling_face:
I hope this feedback is helpful.

Keep up the good work,
Michael

2 Likes

Thanks a lot for your valuable review Michael!

1 Like