Avaliação desejada para a galeria de imagens

MDN Learn
1

Boa tarde, conclui o código com sucesso, peço uma avaliação para confirmar.
https://alpha.sandstorm.io/shared/B7wlyp-K6bNu9F2YLU5A1OKjifhGJv8U5SdATwY3dGW

2

Hi @Elcio_Bernardo_Souto and welcome to the community :wave:

When I open your link I just get an error message

Invalid token: B7wlyp-K6bNu9F2YLU5A1OKjifhGJv8U5SdATwY3dGW

Can you please check your link is correct?

Thanks and have a nice day!
Michael

3

Bom dia michael o link expirou.
Mas peco para tentar este em baixo

4

Hi again, @Elcio_Bernardo_Souto

Thanks for putting the code on GitHub. I had a look and here is my feedback:

  • You have a lot of repetition in your code. This is often a sign that we can improve it. For example inside the for loop you have a lot of if...else statements with nearly the same content. Only the numbers in the image names differ. Since we have our loop variable i that goes from 1 to 5, we could use that to build our image names.

    Instead of

    /* "xxx" was meant as a placeholder for your own code */
newImage.setAttribute('src', xxx);

    you could delete the if...else statements and use

    newImage.setAttribute('src', 'images/pic' + i + '.jpg');

  • A similar case is your thumbBar.onclick event handler. Instead of attaching the event handler to thumbBar we could attach events to every image inside the for loop:

    newImage.onclick = function(e) {
  displayedImage.src = e.target.src;
}

  • Your code for the “Darken/Lighten” button looks good! :+1:
    You could even delete the second if statement and just use } else { since there are only two possibilities (class=“dark” or class=“light”)

I hope this feedback helps you. Feel free to ask questions. I’m happy to help. :blush:

Have a nice day!
Michael

1 Like
5

Muito obrigado por me ajudar a melhorar o meu código @mikoMK,
realmente tinha muitos ‘loops’, mas como sou iniciante, vou aprendendo com o tempo!

peço que continue a ajudar-me

1 Like
6

You are very welcome! I’m glad it was helpful. :slightly_smiling_face:
When you start learning loops it’s pretty hard to understand it. But once you get it, it’s just wonderful to see how small code is able to do big work. I promise when you keep learning, some day you just naturally understand it and know how to use the advantages of loops. :+1:

Michael