Error while upload new version of addon: Icon must be square

agarwal.pankaj.1989 · August 28, 2018, 4:35pm

Hi,

We already having one add-on published in firefox store.
Now while trying to upload new version, we are getting this error :
Error: Icon at “Images/NormalState-48.png” must be square.

Can you guys please help me here ?

Thanks,
Pankaj

freaktechnik · August 28, 2018, 4:36pm

Apparently the icon that’s mentioned in the error message is not exactly 48 by 48 pixel.

juraj.masiar · October 24, 2019, 2:15pm

agarwal.pankaj.1989 · August 28, 2018, 5:59pm

Thanks a lot Martin. I was confused with shape.

And can you tell me is there any changes in code review process for add-on.

because after this change I update my add-on with source code as well, but it just published latest changes instantly and without any code review queue, It used to do same before.

agarwal.pankaj.1989 · August 28, 2018, 6:00pm

Thanks for this beautiful clarification

juraj.masiar · August 28, 2018, 7:01pm

The review process is now done automatically with some build in tests. However based on the score your review gets, you can be flagged for human review and your add-on can be disabled afterwards if it doesn’t meet the requirements.

So make sure you don’t see any warnings in the automatic review report.
Also read carefully the notes during the publish process - these things are explained there.

agarwal.pankaj.1989 · August 31, 2018, 6:31am

Thanks Juraj.
But even though in last update in Aug,2017 we published with complete review process even though 50 warnings were there.

And this time it auto approved with 50-60 warnings.

So does this warning matters now , and not mattered before ?

juraj.masiar · August 31, 2018, 7:41am

Warnings will matter to human reviewer. Else the automatic process cares only about errors.
Can you post some of the warnings here?

agarwal.pankaj.1989 · September 5, 2018, 6:32am

Hi Juraj,

Sorry for late reply.

I’m listing down type of warning here -

The size of the icon does not match the manifest.
“storage.local” can cause issues when loaded temporarily
eval can be harmful.
Unsafe assignment to innerHTML
The Function constructor is eval.
desktopCapture.chooseDesktopMedia is not supported
system.cpu is not supported

juraj.masiar · September 5, 2018, 6:50am

Well this sounds very bad! Especially the eval (but also innerHTML).
And why the icon size doen’t match the manifest?
You should seriously fix all of these warnings if they are in your source code.

agarwal.pankaj.1989 · September 6, 2018, 7:00am

Thanks Juraj,

We will fix this for sure.