Open Source License, but Icons Copyrighted, How to Handle

I’m having my son, who does graphic design, do icons for my extension. (His first paying gig)

While the rest of the extension will be released under the MIT license, his icons will be a part of his portfolio, and he will hold all rights outside of use in the extension. (He typically licenses under Creative Commons Attribution-Noncommercial-Share Alike 3.0 License.)

If I simply add a line to the license to the effect of:

All icons © Charles E. Saroff, 2018, used with permission, all other items licensed under MIT License. (with the MIT license below)

Would that be sufficient, or do I need to go with a different license, or do I need different language in the license statement?

What is your intention regarding re-use of the icons. For example, if someone creates a fork of your add-on to adapt it to a different editor, are they free to re-use the icons or not? How about other re-uses? I don’t think your current text addresses that very clearly.

Forks are definitely an issue, but this is not for a specific editor, it works on browser text boxes.

I’ll definitely look into how to handle forks or other potential reuse.