[Support] Flash Control


(blueskyy) #127

I wasn’t able to duplicate the problem, not sure if I had missed anything…

Test:


#128

I found a way to replicate this pretty consistently.

  1. Start video playing, for testing I used https://www.youtube.com/watch?v=RjtCS0EEoCY

  2. Scroll down & expand some comment threads by clicking some “view all X replies” links

  3. Scroll back up and full-screen the video

  4. Video stops and re-blocks, and can’t immediately be unblocked because the button isn’t on the screen.

  5. Exiting full-screen, you’ll be able to unblock the video button the button will be in random strange places.


(blueskyy) #129

Ok, should be fixed now in v2.1.4 (in the queue, awaiting full review). Thanks.


#130

Awesome, thanks.

Next issue: I stumbled across a site where sound is not blocked at all:

http://gall.dcinside.com/board/view/?id=hearthstone&no=1971193&page=5&exception_mode=recommend

Background music plays automatically. I verified I don’t have anything relevant whitelisted. I do see a blocked Flash icon near the upper-left, but clicking it doesn’t seem to change anything. Also, there appears to be an unblocked Flash object, which I assume is where the music is coming from. Looked at source and found this:

<embed src=“http://player.bgmstore.net/vwC6K” allowscriptaccess=“always” allowfullscreen=“true” width=“422” height=“180”>


(blueskyy) #131

Yes, you’re absolutely right, that’s where the music is coming from. But, if you look at the code, that isn’t a Flash object, it’s an unknown object, ie, it’s an object with no type. Firefox is either smart enough to have detected it as a Flash object internally (by reading the file header, the html mimetype, or other means), or simply just default unknown objects to Flash; Flash Control, on the other hand, can’t do that. Since Flash Control only promises to block Flash objects, it shouldn’t block unknown types, or “malformed” tags, right?


(Frobozz42) #132

AOL Article link

I tried search for previous questions about AOL videos playing but found none. My-Bad if I didn’t search right.

Above link begins playing immediately.

I am using Comodo Icedragon 42.0.0.25 FWIW


(blueskyy) #133

It looks okay to me:
https://youtu.be/vj3yvC7Yyog

ps: For some unknown reason, I did not receive any notification for your reply.


(hmijail) #134

I tried, but I couldn’t find any explanation about this: what are the “F1L” boxes in the Flash Control sidebar? I see that the screenshots at the addon site show that at some previous version those were in fact “F12L”…


#135

I’ve found another site that auto-plays audio and video despite Flash Control being active:

Looked at source and found this:

<a id=“bgndVideo” href=“http://www.youtube.com/watch?v=ygr5AHufBN4” class=“movie {opacity:1, isBgndMovie:{width:‘window’,mute:false}, optimizeDisplay:true, showControls:false, ratio:‘4/3’, loop: true, quality:‘small’,addRaster:true, lightCrop:true}”></a>

Also saw this bit of Javascript that seems relevant:

$(document).bind(“YTPStart”, function(){ $("#loading").fadeOut(3000)});
$("#bgndVideo").mb_YTPlayer();

Any way for Flash Control to block this?


(blueskyy) #136

“F1L” is just the pager. F is the first page, L the last page, and 1 being page 1.


(blueskyy) #137

That is a malformed page. There shouldn’t be any tages between the “<head>” and “<body>” tags. I’ve noted it down. I’ll deal with it when I have the time – make Flash Control less strict to non-compliant sites (i.e. badly written web pages).


#139

I’m running into a browser crash that seems to be related to Flash Control.

  1. Go to https://a.tumblr.com/tumblr_lvgcv2mbao1qjxbkwo1.mp3
  2. Either leave it blocked or press the button to start it playing
  3. Press Ctrl-T to open a new tab
  4. Browser consistently crashes for me at this point.

Crash does not happen in any of the following scenarios:

  1. Domain is whitelisted in Flash Control (however, un-whitelisting it while it’s open can trigger an immediate crash)
  2. “Disable Flash Control” option is enabled
  3. Flash Control is completely disabled through the Extensions menu

Using Windows 64-bit Firefox ESR 45.0.2.

Possibly relevant, I’m also using Tab Mix Plus with the option where opening a new tab duplicates the current tab. However, that may not be relevant because I’m also able to replicate the crash using a single tab (whitelist & then un-whitelist).


(blueskyy) #140

Thank you for your very detailed feedback as always. Yes, going by the description, it is related to Flash Control. I’ll see what I can do.


(Hue) #141

Hi,
would you take a look at these two sites (example links provided) - Flash Control doesn’t seem to stop flash videos from auto playing and i hope there is a solution


(Kernp) #142

Where you get the images? (the one you put in the webpage)
Can i use the html5 video/audio icon?
You created the images?


(blueskyy) #143

Is it that surprising that I created those images. Do it yourself, it’s not that difficult. Go get the official HTML5 icon, color the left and right sides with different colors/shades, if you need a gradient, use a gradient, then type an alphabet on top of it, There, you have your own icon.


(Kernp) #144

What program you using?
But, when i change (must change?) the colors/shades then it looks not like the original html5 icon? Do you changed the colors/shades too? Or is this the original colors/shades?

Your icons are perfect!
I need these icons for my own add-on. (non-commercial ofc)
Your license says: Custom (Free for non-commercial use)?

Can we make a deal?
I give you the code (found out after some testing/time) to handle mediasource videos (e.g. youtube) and i get the two images (fc_play2a.png, fc_play2b.png)?


(FloridaMatt) #145

[non-critical Bug? Weirdness?]
Current Nightly[54]. Adobe Flash installed, up to date, and disabled. Flash control set to block it.
Synology NAS web admin page. Note Synology claims they do not use flash.

If Flash Control is disabled, or the NAS is whitelisted, Firefox does not produce any messages about flash.

If Flash Control is enabled, upper left corner of the web page displays 2 non-clickable Flash Control icons.

Inspect element for one of them looks like this:


#146

I upgraded to Firefox ESR 52 (from ESR 45) and when Flash Control is enabled, something seems to be going haywire when revisiting a YouTube video that has already been partially viewed and YouTube does the thing where it automatically jumps to where the video was previously played to:

http://imgur.com/a/zfBW8

It just does like that forever, or until clicking to play the video. In addition to the cosmetic weirdness, Firefox seems to be wasting a log of bandwidth by downloading a few seconds of video then discarding it and downloading again, over and over again.

Also starting as soon as I upgraded FireFox, I’m sometimes running into this on YouTube, apparently related to waiting more than a few seconds to hit the unblock button on the video.

http://i.imgur.com/KZwltHs.png


(cyrille laloy) #147

Firefox 54-0 (on Arch Linux) ; url filtering via the hosts file: ON.

Hi, thank you for your both proposing your add-on and having this thread on Discourse :slight_smile: I got a IMHO quite interesting issue here.

  1. with latest stable of Flash Control installed from the Add-on tab
  • Youtube videos in FF stop playing, say:

      "An Error Occured. Please try again later"
    
  • Also cli utilities stop being capable to stream any youtube video

      └─> [0]$ youtube-dl https://youtu.be/8OpJtJ1WheE
      [youtube] 8OpJtJ1WheE: Downloading webpage
      ERROR: Unable to download webpage: <urlopen error [Errno 101] Network is unreachable> (caused by URLError(OSError(101, 'Network is unreachable'),))
    
      └─> [0]$ mpv https://www.youtube.com/watch?v=r6qR_CHLXwI
      Playing: https://www.youtube.com/watch?v=r6qR_CHLXwI
      [ytdl_hook] ERROR: Unable to download webpage: <urlopen error [Errno 101] Network is unreachable> (caused by URLError(OSError(101, 'Network is unreachable'),))
      [ytdl_hook] youtube-dl failed, trying to play URL directly ... 
      [ffmpeg] tcp: Connection to tcp://www.youtube.com:443 failed (Connection refused), trying next address
      Failed to open https://www.youtube.com/watch?v=r6qR_CHLXwI.
    
      Exiting... (Errors when loading file)
    
  1. Uninstall Flash Control (replaced with FlashStop in case it makes sens)
  • Youtube (same) videos do play in FF

  • cli utilities can stream them again

      └─> [0]$ mpv https://www.youtube.com/watch?v=r6qR_CHLXwI
      Playing: https://www.youtube.com/watch?v=r6qR_CHLXwI
       (+) Video --vid=1 (*) (h264 1920x1080 30.000fps)
       (+) Audio --aid=1 --alang=eng (*) 'DASH audio' (opus 2ch 48000Hz) (external)
      AO: [pulse] 48000Hz stereo 2ch float
      Using hardware decoding (vaapi).
      VO: [opengl] 1920x1080 vaapi[nv12]
      AV: 00:00:02 / 00:35:24 (0%) A-V:  0.000 Cache: 10s+227KB
      (...)
    

I can reproduce it instantly; any youtube URL will act the same.