Validation failure and warnings

naber · October 23, 2017, 3:01pm

I have two issues with validation:

I get a validation failure when using Javascript’s spread operator (...), even though it seems to work fine in the code. Do I need to remove the use of that operator or is this a bug in the validator?
I get Unsafe assignment to innerHTML warnings in external libraries. How should I deal with those? I don’t want to touch external code, but my add-on has become more complex and I cannot simply do without external libraries.

This will be the first update for my add-on after the new review approach and I’m concerned it might be rejected after being published.

erosman · October 23, 2017, 4:52pm

I use it and no problem.

That depends. It shows that the library is not recognised. Such warnings do not happen on recognised libraries.

github.com

mozilla/amo-validator/blob/master/validator/testcases/hashes-allowed.txt

3ca7274302353b8386c230cfed846b122a97fe60a611ff73e88a657d56cc3a3b angularjs.1.6.6.angular.js
35f73a70cca067828be9e0a712b8b48908e1bc4490637c62bd70158f95cd6e27 angularjs.1.6.6.angular.min.js
918b67113f134ec866265fb26365dc1497c88af997f75bbd70ef8450ca7658e6 backbone.1.0.0.backbone-min.js
2ebbacdc8393dac4ce1d4cfbb8eb1957ba7bd7811fa7bed67c94a4a1193a78f3 backbone.1.0.0.backbone.js
453ec40e1cf3ecc3309a6a5bbf0ae555ee2f5f80075e48e86ce37dc247dc135c backbone.1.1.0.backbone-min.js
5a36cd2b29bc952610f3d8689348056a9a0658014552d77eb47b23bc0f3350a8 backbone.1.1.0.backbone.js
06fac5a66f26137240f94bef2fc0d15f75fa2effe8aec8929b04eb60e6017436 backbone.1.1.1.backbone-min.js
f5f741e7991113473236eb4da601cd50b44bdaea52f3b792a481c588bcd901a4 backbone.1.1.1.backbone.js
75d28344b1b83b5fb153fc5939bdc10b404a754d93f78f7c1c8a8b81de376825 backbone.1.1.2.backbone-min.js
0977290d5e68ce40d516cd4dc3965586680024e51399f0ee54ee8ed3a99b1506 backbone.1.1.2.backbone.js
e2880d9b382972780cbd99f9873c4fdf06618b36a8a3666bdb9d895845816f40 backbone.1.2.0.backbone-min.js
4ac1c9ebee6ebcd1614a8f92d41cb270e61e0b8f61c804c0d1b26fda4b889824 backbone.1.2.0.backbone.js
a593ba9f6e85ce030c59fd367c88b624d267b2a8d895fc7b3dcec52cc5137084 backbone.1.2.1.backbone-min.js
c27c8ad6ec8e148ed22a32035d67582e6affcdfa234e2cb2fac6611dbfd1781a backbone.1.2.1.backbone.js
a7a6e47c5aa6c6d79baca392fb0c868be41fdddd75d5e59440febb91ec9727a4 backbone.1.2.2.backbone-min.js
0b505a72e89152018c40056b6dd713668f96dbf508c0930e6ce7302cb7acfd88 backbone.1.2.2.backbone.js
c3ca23012efd03572816f91fb7addce549b1c9a327703f47735d153db22365fe backbone.1.2.3.backbone-min.js
3dd6732dfa24d1d79279ab81672b2092604b543489af42c7eba281f990c0cc43 backbone.1.2.3.backbone.js
1d9d21d7b55593465f76af4bd0572f414cec6f1e9acbe0a3e1780361b8243daf backbone.1.3.1.backbone-min.js
b432f5da40a1a53b029f51a42aa99ac21bc602d9af942836f8c7b70d3d74da74 backbone.1.3.1.backbone.js

This file has been truncated. show original

If yours is one of those, then make sure it is untouched and matches the hash checksum of the original.

If it is not, then it has to be checked.

naber · October 23, 2017, 5:26pm

Thanks for your reply.

Maybe it’s the way I use it? Validator complains about column 64, which is the beginning of ...:

lastCheckResult = Object.assign({}, lastCheckResult, { ...msg, isProcess: false });

Okay, but what exactly does that mean now? I understand any add-on will be published immediately and the review will follow later. What would happen if the reviewer considered my use of the library not conforming to the rules (which seem to be not specific enough for the case of external libraries)?

erosman · October 23, 2017, 6:41pm

Then it will be rejected.

naber · October 23, 2017, 7:22pm

But what does this mean, considering it has been published already? Will the users who already have the update be downgraded? Or will they stay on the update until a new update addresses the reviewer’s issues?

erosman · October 23, 2017, 8:16pm

The new system is quite new and I personally don’t know how it works out but an add-on can be rejected after the auto-approval. @jorgev should know the details about what happens after an add-on is rejected…