Assessment wanted for 'Marking up a letter' exercise on MDN

MDN Learn
#1

Hi there!

Was just curious and wanted to get my MDN exercise assessed. It’s this exercise here:

I have copied my code into a codepen here:

Thanks in advance!

#2

Hello @jaredstevenson and welcome to the community :wave:

Congratulations! You did a great job on this task :medal_sports:

Some small remarks:

  • It’s not a mistake but as an alternative: Instead of using a <div> around the <address> and <p> you could put the class directly on those two elements. There are some more characters to type but on the other hand you could get rid of the generic <div> and flatten the HTML structure.
  • The <br> after the email address can be omitted since with the closing of the <address> block we get an automatic line break.
  • The links are missing title attributes.

That’s all i could find. :sweat_smile:
As you see, those are only very minor things. You can be proud of your work. :+1:

Have a nice day!
Michael

#3

Thank you very much for the feedback :slight_smile:

1 Like
#4

I’m glad it was helpful.

By the way your email address ended up in the (optional) field for your name. Everyone reading your posts can see it. I recommend removing it from there.