Assessment wanted for Marking up a letter (Feedback Appreciated)

Hi,

I have completed my first assessment over here https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter and would like some feedback, thank you, have a nice day.

Hello @kris_collins

you doing great well done just some notice here :

  1. no need to use div just use address and give it the same class as you did with the div
    as general rule do not use div or span unless there no other option cause div and span has no semantic meaning which will make you to use some aria to give it semantic meaning which you will learn about later

  2. also put the tel and email and Dr. Eleanor Gaye inside the address as it part of it

  3. the only thing that not part of the address is the time element but you would need to wrap it with p element and give it the same class as the address (cause the time is not block element which you will learn about in css leason)

  4. do the same thing with the second address

  5. by the way address make text italic by default

hope that help and have a nice day :slight_smile:

2 Likes

Thanks, it`s really helpful, much appreciated!

1 Like

you very welcome :slight_smile: